SIA-R8: add type="password" (and more) to applicability #1667
Conversation
…. make the tests pass.
…s. inspired act-rules/act-rules.github.io#2123 (comment) - added corresponding unit tests. they pass.
🦋 Changeset detectedLatest commit: f37faf4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 77 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Given that this will require changes in Dory and SI platform (and extension), I think it should be a new version of the rule:
- Create a new
sia-er8directory with this file, same for the tests. - Add a
Versiontag to thetagsarray of the rule, with version 2. - Add the rule to the list of experimental rules.
- Update changeset accordingly.
We'll need to manage it on our side to be able to handle it. From SMART extension, you'll be able to replace R8 by ER8 in the list of rules you run.
Co-authored-by: Jean-Yves Moyen <[email protected]>
Co-authored-by: Jean-Yves Moyen <[email protected]>
Co-authored-by: Jean-Yves Moyen <[email protected]>
Co-authored-by: Jean-Yves Moyen <[email protected]>
Co-authored-by: Jean-Yves Moyen <[email protected]>
Co-authored-by: Jean-Yves Moyen <[email protected]>
Co-authored-by: Jean-Yves Moyen <[email protected]>
Co-authored-by: Jean-Yves Moyen <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
…tType uses (instead of string). as per review comment at Siteimprove#1667 (comment)
Co-authored-by: Jean-Yves Moyen <[email protected]>
(as per review comment at Siteimprove#1667 (review) ) so this commit effectively reverts sia-r8.
|
@Jym77 there is a new problem that I don't understand, and I don't know if it's a real problem or not: a certain github action failed with this message:
So I tried some things, but nothing was fruitful. Any thoughts? |
You need to update the API extraction (which is then used to build some documentation at release time) by running locally |
|
!pr extract |
|
@Jym77 Excellent. I've noted this "pr extract" and this PR in general for the future, because it contains a lot of generic advice and alfa conventions. At any rate, I think that I've acted on all of the points in your review. What should I do next? |
Co-authored-by: Jean-Yves Moyen <[email protected]>
Co-authored-by: Jean-Yves Moyen <[email protected]>
Co-authored-by: Jean-Yves Moyen <[email protected]>
Co-authored-by: Jean-Yves Moyen <[email protected]>
|
@Jym77 Thank you - not only for this PR review for the immediate goal, but also for the future reference on alfa conventions that this PR review will serve as (the next time I make a PR). I've "resolved" everything again so it's over to you, again. |
|
!pr extract |
|
I'm merging this now because I'm going to make conflicting changes, will be easier to start from the new state. |
This PR was motivated by the fact that I want to add sia-r8 to the SMART browser extension, and I want it to have applicability which covers
<input type="password">elements, and I don't want to copy-and-paste alfa code into SMART in order to accomplish that.And of course, I hope that it's useful to alfa users in general.
My only current concrete need in SMART is for
type="password", but this PR also contains a few more types: color, date, datetime-local, file, month, time, and week. I got this list from Mark's comment here.